From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC Date: Tue, 27 Mar 2018 18:33:54 +0200 Message-ID: <3396888.LEadjR7LpM@xps> References: <5d94df0912159b96aa71da5249598bd8c744a198.1522159146.git.anatoly.burakov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, jianfeng.tan@intel.com, konstantin.ananyev@intel.com, harry.van.haaren@intel.com To: Anatoly Burakov Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 7F9DE44CF for ; Tue, 27 Mar 2018 18:34:10 +0200 (CEST) In-Reply-To: <5d94df0912159b96aa71da5249598bd8c744a198.1522159146.git.anatoly.burakov@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/03/2018 15:59, Anatoly Burakov: > Under the hood, we create a separate thread to deal with replies to > asynchronous requests, that will just wait to be notified by the > main thread, or woken up on a timer. I really don't like that a library is creating a thread. We don't even know where the thread is created (which core). Can it be a rte_service? or in the interrupt thread? > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -225,6 +225,7 @@ EXPERIMENTAL { > rte_mp_action_unregister; > rte_mp_sendmsg; > rte_mp_request; > + rte_mp_request_async; So there is rte_mp_request and rte_mp_request_async? You should rename rte_mp_request, I guess. > rte_mp_reply; > rte_service_attr_get; > rte_service_attr_reset_all;