From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2] net/i40e: fix Tx fn selection when using new ethdev offloads Date: Tue, 1 May 2018 15:37:05 +0100 Message-ID: <33c051c4-a338-ba1e-749c-e0b12bd1414d@intel.com> References: <20180501130309.39444-1-bruce.richardson@intel.com> <20180501141354.13935-1-bruce.richardson@intel.com> <20180501141620.GA47736@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, konstantin.ananyev@intel.com To: Bruce Richardson , Beilei Xing , Qi Zhang Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 83C0F29AC for ; Tue, 1 May 2018 16:37:08 +0200 (CEST) In-Reply-To: <20180501141620.GA47736@bricha3-MOBL.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/1/2018 3:16 PM, Bruce Richardson wrote: > On Tue, May 01, 2018 at 03:13:54PM +0100, Bruce Richardson wrote: >> The Tx function selection code in the driver only used the older txq >> flags values to check whether the scalar or vector functions should be >> used. This caused performance regressions with testpmd io-fwd as the >> scalar path rather than the vector one was being used in the default >> case. Fix this by changing the code to take account of new offloads and >> deleting the defines used for the old ones. >> >> Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API") >> >> Signed-off-by: Bruce Richardson >> --- > Apologies: forgot to add: > > v2: eliminate mask for offload flags, and use vector path only if > offloads == 0 > Reviewed-by: Ferruh Yigit