From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] net/tap: remove queue specific offload support Date: Wed, 18 Apr 2018 09:59:26 +0100 Message-ID: <33d0cd29-855e-58dd-683d-e540a7978515@intel.com> References: <20180322182843.105732-1-ferruh.yigit@intel.com> <2913888.DGWfva7bOG@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Shahaf Shuler , Olga Shern To: Thomas Monjalon , Pascal Mazon , motih@mellanox.com, ophirmu@mellanox.com Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 796587ED4 for ; Wed, 18 Apr 2018 10:59:32 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/12/2018 5:23 PM, Ferruh Yigit wrote: > On 4/5/2018 6:49 PM, Thomas Monjalon wrote: >> Pascal, Moti, Ophir, >> please comment. > > Hi Moti, > > Any comment? This has been asked many times now. Hi Moti, Ophir, You have not responded why queue specific offload added in other thread. And you are not responding to this patch... Hi Pascal, If you also have no objection, this patch is going in. Thanks, ferruh > >> >> 22/03/2018 19:28, Ferruh Yigit: >>> It is not clear if tap PMD supports queue specific offloads, removing >>> the related code. >>> >>> Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API") >>> Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API") >>> Cc: motih@mellanox.com >>> >>> Signed-off-by: Ferruh Yigit >> >> >> >