From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v5 1/2] tools: Add support for handling built-in kernel modules Date: Tue, 26 Jan 2016 16:12:16 +0100 Message-ID: <3408742.MAgGxnHKYz@xps13> References: <1449588833-485-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com> <1540084.9SflLyUVmh@xps13> <569E65ED.9060007@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Kamil Rytarowski Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 1CE3F9235 for ; Tue, 26 Jan 2016 16:13:25 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id u188so110436412wmu.1 for ; Tue, 26 Jan 2016 07:13:25 -0800 (PST) In-Reply-To: <569E65ED.9060007@caviumnetworks.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-01-19 17:35, Kamil Rytarowski: > > W dniu 18.01.2016 o 15:32, Thomas Monjalon pisze: > > Hi Kamil, > > > > 2015-12-09 14:19, Kamil Rytarowski: > >> Currently dpdk_nic_bind.py detects Linux kernel modules via reading > >> /proc/modules. Built-in ones aren't listed there and therefore they are not > >> being found by the script. > >> > >> Add support for checking built-in modules with parsing the sysfs files. > >> > >> This commit obsoletes the /proc/modules parsing approach. > >> > >> Signed-off-by: Kamil Rytarowski > > I have a doubt about this tag: > >> Signed-off-by: David Marchand > > What do you mean here? > > Excuse me, it should be: Acked-by: David Marchand > > > http://dpdk.org/ml/archives/dev/2015-December/029720.html The ack was only for the patch 2/2