From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] mk: replace the combined library with a linker script Date: Tue, 01 Mar 2016 14:40:46 +0100 Message-ID: <3419544.3hNz4j3KVF@xps13> References: <079fa1cfc3550c8147ea8b137fa1bc0f34d051dc.1448375477.git.pmatilai@redhat.com> <1456266011-23701-1-git-send-email-thomas.monjalon@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: pmatilai@redhat.com, Neil Horman , Sergio Gonzalez Monroy Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 9042A201 for ; Tue, 1 Mar 2016 14:42:22 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id l68so33923199wml.1 for ; Tue, 01 Mar 2016 05:42:22 -0800 (PST) In-Reply-To: <1456266011-23701-1-git-send-email-thomas.monjalon@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ping I would like to be sure nothing is forgotten in this new revision. 2016-02-23 23:20, Thomas Monjalon: > From: Panu Matilainen > > The physically linked-together combined library has been an increasing > source of problems, as was predicted when library and symbol versioning > was introduced. Replace the complex and fragile construction with a > simple linker script which achieves the same without all the problems, > remove the related kludges from eg mlx drivers. > > Since creating the linker script is practically zero cost, remove the > config option and just create it always. > > Based on a patch by Sergio Gonzales Monroy, linker script approach > initially suggested by Neil Horman. > > Suggested-by: Sergio Gonzalez Monroy > Suggested-by: Neil Horman > Signed-off-by: Panu Matilainen > Signed-off-by: Thomas Monjalon > --- > v2: > - move RTE_LIBNAME assignment rte.vars.mk to rte.combinedlib.mk > - update crypto > - update doc > - update rte.app.mk > - update test-build.sh