From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 2/3] eal: add new rte color definition Date: Tue, 18 Dec 2018 13:38:10 +0100 Message-ID: <34337288.XBznk5NxM7@xps> References: <20181123165423.134922-1-jasvinder.singh@intel.com> <1646379.j0tofnCs90@xps> <3EB4FA525960D640B5BDFFD6A3D891268E81658C@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "Pattan, Reshma" , "dev@dpdk.org" , "Ananyev, Konstantin" , "jerin.jacob@caviumnetworks.com" , "Singh, Jasvinder" , "david.marchand@redhat.com" , olivier.matz@6wind.com To: "Dumitrescu, Cristian" Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id F2AF61B58D for ; Tue, 18 Dec 2018 13:38:15 +0100 (CET) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E81658C@IRSMSX108.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/12/2018 12:18, Dumitrescu, Cristian: > > > I replied in v3 that it should stay in rte_meter.h. > > > You can include rte_meter.h in ethdev. > > > > OK, thanks Thomas, makes sense to me as well. > > > > Thomas, > > I agree with your input, but just want to make sure we are on the same page: > > Besides including rte_meter.h in ethdev (which you are fine with), we would also need to include rte_meter.h in mbuf. > > Are you OK with this as well? Why do we need rte_meter.h in mbuf?