From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3] libs/power: add p-state driver
	compatibility
Date: Fri, 21 Dec 2018 01:30:24 +0100
Message-ID: <3440914.i2vn9u2s4q@xps>
References: <1544786028-10138-1-git-send-email-liang.j.ma@intel.com>
 <1867163.ZjDIE9iX7y@xps> <546f1cd6-6f02-95ef-008a-d0885f6b53e0@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, anatoly.burakov@intel.com
To: "Hunt, David" <david.hunt@intel.com>, Liang Ma <liang.j.ma@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4494E1BD4B
 for <dev@dpdk.org>; Fri, 21 Dec 2018 01:30:27 +0100 (CET)
In-Reply-To: <546f1cd6-6f02-95ef-008a-d0885f6b53e0@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

20/12/2018 15:52, Hunt, David:
> On 19/12/2018 8:31 PM, Thomas Monjalon wrote:
> > 19/12/2018 10:09, Hunt, David:
> >> On 19/12/2018 3:18 AM, Thomas Monjalon wrote:
> >>> 14/12/2018 14:11, Liang Ma:
> >>>> Previously, in order to use the power library, it was necessary
> >>>> for the user to disable the intel_pstate driver by adding
> >>>> =E2=80=9Cintel_pstate=3Ddisable=E2=80=9D to the kernel command line =
for the system,
> >>>> which causes the acpi_cpufreq driver to be loaded in its place.
> >>>>
> >>>> This patch adds the ability for the power library use the intel-psta=
te
> >>>> driver.
> >>>>
> >>>> It adds a new suite of functions behind the current power library AP=
I,
> >>>> and will seamlessly set up the user facing API function pointers to
> >>>> the relevant functions depending on whether the system is running wi=
th
> >>>> acpi_cpufreq kernel driver, intel_pstate kernel driver or in a guest,
> >>>> using kvm. The library API and ABI is unchanged.
> >>>>
> >>>> Signed-off-by: Liang Ma <liang.j.ma@intel.com>
> >>>>
> >>>> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >>>> ---
> >>> Please write a changelog when sending a new version.
> >>>
> >>> Dave, any comment on this patch?
> >>
> >> Looks good to me.
> >>
> >> Acked-by: David Hunt <david.hunt@intel.com>
> >>
> >>
> >>>> --- /dev/null
> >>>> +++ b/lib/librte_power/power_pstate_cpufreq.c
> >>>> @@ -0,0 +1,770 @@
> >>>> +/* SPDX-License-Identifier: BSD-3-Clause
> >>>> + * Copyright(c) 2018-2018 Intel Corporation
> >>> Something wrong here :)
> >> Yes, should simply be "Copyright(c) 2018 Intel Corporation"
> >
> > There is also a compilation error with meson:
> >
> > lib/librte_power/rte_power_empty_poll.h:20:10: fatal error:
> > 	rte_timer.h: No such file or directory
> >
> > Clearly, some quality checks are missing.
> >
> > I'm afraid we won't have any patch for power library in 19.02.
>=20
>=20
> Hi Thomas,
>=20
> We have just pushed a v4, and tested with make, meson/ninja, and several=
=20
> different build environments. I believe this version should be=20
> acceptable for 19.02.

I don't think so.
I will give more comments in v4 and will give up for 19.02.