From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH]  app/proc-info:fix port mask parse bug
Date: Mon, 05 Nov 2018 12:41:14 +0100
Message-ID: <3442683.FcHu0NKpy2@xps>
References: <1538031669-9305-1-git-send-email-han.li1@zte.com.cn>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Li Han <han.li1@zte.com.cn>, maryam.tahhan@intel.com
To: Reshma Pattan <reshma.pattan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D3CFE2C52
 for <dev@dpdk.org>; Mon,  5 Nov 2018 12:41:17 +0100 (CET)
In-Reply-To: <1538031669-9305-1-git-send-email-han.li1@zte.com.cn>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

+Cc Reshma

Please could you review this patch?


27/09/2018 09:01, Li Han:
> parse_portmask return type is int,but global variable
> "enabled_port_mask" type is uint32_t.so in proc_info_parse_args
> function,when parse_portmask return -1,"enabled_port_mask" will
> get a huge value and "if (enabled_port_mask == 0)" will never happen.
> 
> Signed-off-by: Li Han <han.li1@zte.com.cn>
> ---
>  app/proc-info/main.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/app/proc-info/main.c b/app/proc-info/main.c
> index c20effa..5b06735 100644
> --- a/app/proc-info/main.c
> +++ b/app/proc-info/main.c
> @@ -90,7 +90,7 @@
>  /*
>   * Parse the portmask provided at run time.
>   */
> -static int
> +static uint32_t
>  parse_portmask(const char *portmask)
>  {
>  	char *end = NULL;
> @@ -103,13 +103,10 @@
>  	if ((portmask[0] == '\0') || (end == NULL) || (*end != '\0') ||
>  		(errno != 0)) {
>  		printf("%s ERROR parsing the port mask\n", __func__);
> -		return -1;
> +		return 0;
>  	}
>  
> -	if (pm == 0)
> -		return -1;
> -
> -	return pm;
> +	return (uint32_t)pm;
>  
>  }