From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] app/testpmd: fix default RX/TX flow control
	values
Date: Mon, 15 Jun 2015 11:53:22 +0200
Message-ID: <3444705.8u2oBuzF7f@xps13>
References: <1433160669-20810-1-git-send-email-david.marchand@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: David Marchand <david.marchand@6wind.com>, Ding Zhi <zhi.ding@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
 [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 14A0B1288
 for <dev@dpdk.org>; Mon, 15 Jun 2015 11:54:20 +0200 (CEST)
Received: by wiwd19 with SMTP id d19so69508068wiw.0
 for <dev@dpdk.org>; Mon, 15 Jun 2015 02:54:19 -0700 (PDT)
In-Reply-To: <1433160669-20810-1-git-send-email-david.marchand@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> This variable has undefined values in some cases.
> 
> Fixes: 422a20a4e62d ("app/testpmd: fix uninitialized flow control variables")
> Signed-off-by: Ding Zhi <zhi.ding@6wind.com>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
[...]
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -4743,7 +4743,7 @@ cmd_link_flow_ctrl_set_parsed(void *parsed_result,
>  	struct cmd_link_flow_ctrl_set_result *res = parsed_result;
>  	cmdline_parse_inst_t *cmd = data;
>  	struct rte_eth_fc_conf fc_conf;
> -	int rx_fc_en, tx_fc_en = 0;
> +	int rx_fc_en = 0, tx_fc_en = 0;
>  	int ret;

Applied with lines split to conform with the coding rules:
http://dpdk.org/browse/dpdk/tree/doc/guides/guidelines/coding_style.rst#n461