From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] ethdev: fix statistics description
Date: Mon, 07 Nov 2016 21:37:02 +0100
Message-ID: <3445523.JqAozkltlD@xps13>
References: <1472206104-22035-1-git-send-email-wei.dai@intel.com>
 <49759EB36A64CF4892C1AFEC9231E8D63A2EB13C@PGSMSX106.gar.corp.intel.com>
 <98CBD80474FA8B44BF855DF32C47DC359EA906@smartserver.smartshare.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: Morten =?ISO-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>, "Mcnamara,
 John" <john.mcnamara@intel.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, "Wu,
 Jingjing" <jingjing.wu@intel.com>, "Zhang, Helin" <helin.zhang@intel.com>,
 "Curran, Greg" <greg.curran@intel.com>, dev@dpdk.org
To: "Dai, Wei" <wei.dai@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id D755D9E3
 for <dev@dpdk.org>; Mon,  7 Nov 2016 21:37:04 +0100 (CET)
Received: by mail-wm0-f47.google.com with SMTP id p190so207107560wmp.1
 for <dev@dpdk.org>; Mon, 07 Nov 2016 12:37:04 -0800 (PST)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC359EA906@smartserver.smartshare.dk>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-11-02 10:21, Morten Br=F8rup:
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > 2016-08-26 18:08, Wei Dai:
> > > >  /**
> > > >   * A structure used to retrieve statistics for an Ethernet por=
t.
> > > > + * Not all statistics fields in struct rte_eth_stats are suppo=
rted
> > > > + * by any type of network interface card (NIC). If any statist=
ics
> > > > + * field is not supported, its value is 0 .
> > > >   */
> > > >  struct rte_eth_stats {
> > >
> > > I'm missing the point of this patch.
> > > Why do you think it is a fix?
> > >
> > > John, any opinion?
>=20
> I think the source code comment is an improvement.
[...]

Applied as an improvement (not a fix).