From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] cryptodev: mark experimental state
Date: Thu, 26 Nov 2015 11:08:46 +0100
Message-ID: <34498752.nGP1cUxCqE@xps13>
References: <1448473135-19604-1-git-send-email-thomas.monjalon@6wind.com>
 <5656B71D.7030704@redhat.com> <5656BC09.20307@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Panu Matilainen <pmatilai@redhat.com>, declan.doherty@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id 26088C35C
 for <dev@dpdk.org>; Thu, 26 Nov 2015 11:10:05 +0100 (CET)
Received: by wmvv187 with SMTP id v187so23743396wmv.1
 for <dev@dpdk.org>; Thu, 26 Nov 2015 02:10:04 -0800 (PST)
In-Reply-To: <5656BC09.20307@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-11-26 10:00, Panu Matilainen:
> On 11/26/2015 09:39 AM, Panu Matilainen wrote:
> > On 11/25/2015 07:38 PM, Thomas Monjalon wrote:
> >> --- a/config/common_linuxapp
> >> +++ b/config/common_linuxapp
> >> @@ -319,6 +319,7 @@ CONFIG_RTE_PMD_PACKET_PREFETCH=y
> >>
> >>   #
> >>   # Compile generic crypto device library
> >> +# EXPERIMENTAL: API may change without prior notice
> >>   #
> >>   CONFIG_RTE_LIBRTE_CRYPTODEV=y
> >>   CONFIG_RTE_LIBRTE_CRYPTODEV_DEBUG=n
> > [...]
> >
> > I think an experimental library which declares itself exempt from the
> > ABI policy should not be compiled by default. That way anybody wanting
> > to try it out will be forced to notice the experimental status.
> >
> > More generally / longer term, perhaps there should be a
> > CONFIG_RTE_EXPERIMENTAL which wraps all experimental features and
> > defaults to off.
> 
> On a related note, librte_mbuf_offload cannot be built if 
> CONFIG_RTE_LIBRTE_CRYPTODEV is disabled. Which seems to suggest its (at 
> least currently) so tightly couple to cryptodev that perhaps it too 
> should be marked experimental and default to off.

I think you are right.
Declan, what is your opinion?