From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Doherty, Declan" <declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v11 0/5] link bonding library
Date: Mon, 30 Jun 2014 09:28:16 +0000
Message-ID: <345C63BAECC1AD42A2EC8C63AFFC3ADC2730631F@IRSMSX101.ger.corp.intel.com>
References: <1403864324-12022-1-git-send-email-declan.doherty@intel.com>
 <1404064161-26370-1-git-send-email-declan.doherty@intel.com>
 <13010138.0NjEKNQfRt@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <13010138.0NjEKNQfRt@xps13>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> Sent: Monday, June 30, 2014 10:21 AM
> To: Doherty, Declan
> Cc: dev-VfR2kkLFssw@public.gmane.org
> Subject: Re: [PATCH v11 0/5] link bonding library
>=20
> Hi Declan,
>=20
> 2014-06-29 18:49, Declan Doherty:
> > This patchset contains the name change fix in the link bonding library
> > makefile. I have also put a change into the unit test application makef=
ile
> > so that the link bonding tests are not built if the library is also not
> > being built. It doesn't make sense to split the bonding libraries APIs =
into
> > a seperate library, as they are directly coupled to with the bonding
> > library implmentation
>=20
> You fixed optional building but there is still an issue when building sha=
red
> library.
> As you don't want to split the library to separate the PMD plugin from th=
e
> specific API, I suggest to not consider it as a plugin (unlike other PMDs=
).
>=20
> I've sent some patches about these 2 topics.
> If you agree, I'll apply them, merged with your serie.
>=20
> Thanks
> --
> Thomas

Hi Thomas,
I'm happy for you to apply the makefile changes you have suggested and not=
=20
consider the bonding PMD as a plugin, I  think this makes the most sense
considering it is a purely software library.=20

Thanks
Declan