From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Doherty, Declan" Subject: Re: [PATCH v7 0/7] link bonding Date: Mon, 24 Nov 2014 16:24:24 +0000 Message-ID: <345C63BAECC1AD42A2EC8C63AFFC3ADC274244EC@IRSMSX101.ger.corp.intel.com> References: <1415362978-6306-1-git-send-email-declan.doherty@intel.com> <1416832054-24086-1-git-send-email-declan.doherty@intel.com> <1498541.nlX6zYGF9a@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Thomas Monjalon Return-path: In-Reply-To: <1498541.nlX6zYGF9a@xps13> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hey, sorry about that, I submitted the patchset without the typo fix. I'll = resubmit the patchset now. What version of checkpatch are you using, I don't get any warning for the m= issing spaces for the version of the script with kernel 3.15 on Fedora Thanks Declan > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > Sent: Monday, November 24, 2014 3:36 PM > To: Doherty, Declan > Cc: dev-VfR2kkLFssw@public.gmane.org > Subject: Re: [PATCH v7 0/7] link bonding >=20 > Hi Declan, >=20 > There are still 2 kind of errors reported by checkpatch: > - 14 occurrences of this typo: > WARNING:TYPO_SPELLING: 'interupt' may be misspelled - perhaps 'interrupt'= ? > - 6 occurences of missing space: > WARNING:MISSING_SPACE: break quoted strings at a space character >=20 > Example: > #2016: FILE: lib/librte_pmd_bond/rte_eth_bond_pmd.c:1420: > + "LSC polling interval can be specified on= ly once for bonded" > + "device %s\n", name); > You should put a space between "bonded" and "device". >=20 > -- > Thomas