From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal: fixup hotplugging an already present
	device
Date: Thu, 25 Oct 2018 13:49:26 +0200
Message-ID: <3469600.mFqcC2W9gb@xps>
References: <20181025105101.137701-1-dariusz.stojaczyk@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, stable@dpdk.org
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20181025105101.137701-1-dariusz.stojaczyk@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

25/10/2018 12:51, Darek Stojaczyk:
> We were returning rc = -1 from a device probing function
> whenever the provided device was already probed before.
> 
> This basically broke hotplugging a device in secondary
> process when the same device was already hotplugged in
> the primary.
> 
> To fix it, just return 0 instead of -1. I believe this is
> the originally intented behavior.

The intent was to return the error seen during probing again.
If there is no error, the PMD must return 0.
It means I reject this patch so far.