From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] examples/distributor: fix missing ";
	" in debug macro
Date: Mon, 22 Jun 2015 22:53:25 +0200
Message-ID: <3471063.5PjCouUNn0@xps13>
References: <1433520077-11234-1-git-send-email-bruce.richardson@intel.com>
 <19910784.6F5piXXB0d@xps13> <20150608105810.GC3996@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41])
 by dpdk.org (Postfix) with ESMTP id 687ABC7BC
 for <dev@dpdk.org>; Mon, 22 Jun 2015 22:54:28 +0200 (CEST)
Received: by wguu7 with SMTP id u7so79525740wgu.3
 for <dev@dpdk.org>; Mon, 22 Jun 2015 13:54:28 -0700 (PDT)
In-Reply-To: <20150608105810.GC3996@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-06-08 11:58, Bruce Richardson:
> On Fri, Jun 05, 2015 at 10:45:04PM +0200, Thomas Monjalon wrote:
> > It shows that such dead code is almost never tested.
> > It would be saner if this command would return no result:
> > 	git grep 'ifdef.*DEBUG' examples
> > 		examples/distributor/main.c:#ifdef DEBUG
> > 		examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
> > 		examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
> > 		examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
> > 		examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
> > 		examples/packet_ordering/main.c:#ifdef DEBUG
> > 		examples/vhost/main.c:#ifdef DEBUG
> > 		examples/vhost/main.h:#ifdef DEBUG
> > 		examples/vhost_xen/main.c:#ifdef DEBUG
> > 		examples/vhost_xen/main.h:#ifdef DEBUG
> > 
> > There is no good reason to not use CONFIG_RTE_LOG_LEVEL to trigger debug build.
> > 
> I agree and disagree. 
> 
> I agree it would be good if we had a standard way of setting up
> a DEBUG build that would make it easier to test and pick up on this sort of things.
> 
> I disagree that the compile time log level is the way to do this. The log level
> at compile time specifies the default log level only, the actual log level is
> controllable at runtime. Having the default log level also affect what kind of
> build is done, e.g. with -O0 rather than -O3, introduces an unnecessary dependency.
> Setting the default log level to 5 and changing it to 9 at runtime should be
> the same as setting the default to 9.

Setting CONFIG_RTE_LOG_LEVEL to 9 means we don't care about performance
degradation due to debug log branches. So it is necessarily a debug build.
Then the default log level must be set by the application.
The EAL default set from CONFIG_RTE_LOG_LEVEL is a last chance default in
case the application doesn't care about it.

Maybe it won't convince you but anyway, it's not important here because the
example applications don't use the DEBUG flag for anything else than the logs.
That's why I think these flags must be removed.
Please check "git grep 'ifdef.*DEBUG' examples".