From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v9 3/4] examples: add l3fwd-thread example in
	performance-thread
Date: Tue, 08 Dec 2015 03:28:37 +0100
Message-ID: <3478154.NlCHqoNvP3@xps13>
References: <1449225265-14480-2-git-send-email-ian.betts@intel.com>
 <1915132.14VGSMCEh2@xps13>
 <877C1F8553E92F43898365570816082F35C0C401@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Betts, Ian" <ian.betts@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53])
 by dpdk.org (Postfix) with ESMTP id 3923011C5
 for <dev@dpdk.org>; Tue,  8 Dec 2015 03:29:50 +0100 (CET)
Received: by wmww144 with SMTP id w144so11716053wmw.0
 for <dev@dpdk.org>; Mon, 07 Dec 2015 18:29:50 -0800 (PST)
In-Reply-To: <877C1F8553E92F43898365570816082F35C0C401@IRSMSX103.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-12-08 01:54, Betts, Ian:
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] 
> Sent: Tuesday, December 8, 2015 1:36 AM
> To: Betts, Ian
> Cc: dev@dpdk.org; stephen@networkplumber.org; Richardson, Bruce
> Subject: Re: [PATCH v9 3/4] examples: add l3fwd-thread example in performance-thread
> 
> > +M: Ian Betts <ian.betts@intel.com>
> > +M: John McNamara <john.mcnamara@intel.com>
> > +F: doc/guides/sample_app_ug/performance_thread.rst
> 
> > Why doing 2 sections?
> > John is already the doc maintainer. You don't need to add him here.
> 
> I just copy most of the other examples which also do this.
> I also thought it was odd.

No, John is really the co-maintainer of some examples.
Please talk with him, you are in the same company.

> I will remove him.
> 
> > --- a/examples/Makefile
> > +++ b/examples/Makefile
> > @@ -77,5 +77,9 @@ DIRS-y += vmdq
> >  DIRS-y += vmdq_dcb
> >  DIRS-$(CONFIG_RTE_LIBRTE_POWER) += vm_power_manager
> >  DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += l2fwd-crypto
> > -
> > +ifneq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),)
> > +ifneq ($(CONFIG_RTE_ARCH_X86_64),)
> > +DIRS-y += performance-thread
> > +endif
> > +endif
> 
> > Matter of taste, I would prefer DIRS-$(CONFIG_RTE_ARCH_X86_64)
> 
> I need to combine CONFIG_RTE_EXEC_ENV_LINUXAPP ( the two clauses )

+ifneq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),)
+DIRS-$(CONFIG_RTE_ARCH_X86_64) += performance-thread
+endif

It highlights the main dependency of this code: x86