From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] net/failsafe: fix Rx interrupt reinstallation Date: Wed, 14 Feb 2018 16:28:09 +0100 Message-ID: <3483039.NpOkmzl4zC@xps> References: <1518562772-29823-1-git-send-email-matan@mellanox.com> <1518619646-23990-1-git-send-email-matan@mellanox.com> <20180214150013.qejbi426ajglhuua@bidouze.vm.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, =?ISO-8859-1?Q?Ga=EBtan?= Rivet To: Matan Azrad Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id D50E12BAE for ; Wed, 14 Feb 2018 16:28:21 +0100 (CET) In-Reply-To: <20180214150013.qejbi426ajglhuua@bidouze.vm.6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/02/2018 16:00, Ga=EBtan Rivet: > On Wed, Feb 14, 2018 at 02:47:26PM +0000, Matan Azrad wrote: > > Fail-safe dev_start() operation can be called by both the application > > and the hot-plug alarm mechanism. > >=20 > > The installation of Rx interrupt are triggered from dev_start() in any > > time it is called while actually the Rx interrupt should be installed > > only by the application calls. > >=20 > > So, each plug-in event causes reinstallation which causes memory leak > > and spoils the fail-safe Rx interrupt mechanism. > >=20 > > Trigger the Rx interrupt installation only when it does not exist. > >=20 > > Fixes: 9e0360aebf23 ("net/failsafe: register as Rx interrupt mode") > >=20 > > Signed-off-by: Matan Azrad >=20 > Acked-by: Gaetan Rivet Applied, thanks