From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 1/2] kni: fix build for 5.0 for dev_open()
Date: Tue, 22 Jan 2019 16:59:27 +0000
Message-ID: <34834d92-8258-97b6-c7b2-2821b679452d@intel.com>
References: <20190122154429.41882-1-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Thomas Monjalon <thomas@monjalon.net>, dpdk-techboard <techboard@dpdk.org>
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20190122154429.41882-1-ferruh.yigit@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/22/2019 3:44 PM, Ferruh Yigit wrote:
> Build error seen with Linux kernel 5.0 and
> when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.
> 
> build error:
> .../build/build/kernel/linux/kni/ixgbe_ethtool.c:1746:4:
>   error: too few arguments to function ‘dev_open’
>     dev_open(netdev);
>     ^~~~~~~~
> In file included from .../build/kernel/linux/kni/ixgbe_ethtool.c:18:
> .../linux/linux/include/linux/netdevice.h:2620:5: note: declared here
>  int dev_open(struct net_device *dev, struct netlink_ext_ack *extack);
>      ^~~~~~~~
> 
> .../build/build/kernel/linux/kni/igb_ethtool.c:1812:4:
>   error: too few arguments to function ‘dev_open’
>     dev_open(netdev);
>     ^~~~~~~~
> In file included from .../build/build/kernel/linux/kni/igb_ethtool.c:15:
> .../linux/linux/include/linux/netdevice.h:2620:5: note: declared here
>  int dev_open(struct net_device *dev, struct netlink_ext_ack *extack);
>      ^~~~~~~~
> 
> dev_open() is changed in Linux kernel version 5.0 and now requires
> a new parameter, 'struct netlink_ext_ack *extack'.
> Fixed by defining dev_open as macro when kernel version >= 5.0
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Off the topic.

This is the patch 50000 in patchwork! This is a big number.
Thanks everyone contributed!

https://patches.dpdk.org/patch/50000/

The historical numbers from DPDK patchwork:
50000 - Jan. 22, 2019 (253 days) [ 8 months, 8 days / 36 weeks and 1 day ]
40000 - May. 14, 2018 (217 days)
30000 - Oct. 9, 2017 (258 days)
20000 - Jan. 25, 2017 (372 days)
10000 - Jan. 20, 2016 (645 days)
00001 - April 16, 2014


This is the first time DPDK patch pace slowed down (slightly), I guess this is
because of the holidays in the middle and small 19.02, but I think next
milestone which includes 19.05 will clarify this.