From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 09/11] device-args: replace use-device eal
	option	by pci-whitelist and vdev
Date: Mon, 24 Mar 2014 23:39:25 +0100
Message-ID: <34903726.bp1idtuf7I@xps13>
References: <1393608350-4431-1-git-send-email-olivier.matz@6wind.com>
 <5315D081.20506@6wind.com>
 <59AF69C657FD0841A61C55336867B5B01A9A1AC3@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: "Richardson, Bruce" <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
 Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <59AF69C657FD0841A61C55336867B5B01A9A1AC3-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi,

04/03/2014 13:14, Richardson, Bruce:
> 04/03/2014 14:09, Olivier MATZ:
> > My initial concern was that --use-device has 2 different significations,
> > depending on the format of arguments:
> >    - instanciate a virtual driver if it looks like a vdev name
> >    - add a PCI device to the whitelist if it looks like a pci address
> > I also find strange that instanciating a virtual device changes the PCI
> > mode to whitelist, even if it could be fixed by adding a specific argument
> > for that.
>
> [BR] I agree that having the mode change silently like that was probably not
> the best design. I therefore, agree that a flag should be used to switch
> from normal to whitelist mode, I just think that thereafter the devices of
> whatever type should all be enumerated using a common flag parameter.

I think we should split this in 2 functions because they have totally 
different meaning:
	- create a virtual device and instantiate a driver
	- whitelist a physical device for driver probing
Using the same option for vdev and whitelist would be even more confusing in 
case of blacklist because drivers would probe explicitly listed vdevs and PCI 
devs which are not blacklisted.

-- 
Thomas