From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Chen, Jing D" <jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v2 1/6] ether: enhancement for VMDQ support
Date: Tue, 04 Nov 2014 09:53:43 +0100 [thread overview]
Message-ID: <3494957.2Q8m5MX3oE@xps13> (raw)
In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D016061A7-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-04 05:50, Chen, Jing D:
> From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> > 2014-10-16 18:07, Chen Jing D:
> > > + /** Specify the queue range belongs to VMDQ pools if VMDQ
> > applicable. */
> > > + uint16_t vmdq_queue_base;
> > > + uint16_t vmdq_queue_num;
> >
> > Please explain what mean the values in vmdq_queue_base and
> > vmdq_queue_num.
>
> I thinks the name is self- explanatory, I also add some comments for them.
> As previous max_rx/tx_queues indicates how many queues available, these
> 2 variables defines the queue ranges for VM usage.
I understand clearly now.
> What kind of explanations you needs me to add?
You cannot put a doxygen comment which apply to 2 fields.
Try do describe precisely the meaning of each field.
Example: /**< first queue ID in the range for VMDQ pool */
and /**< size of the queue range for VMDQ pool */
--
Thomas
next prev parent reply other threads:[~2014-11-04 8:53 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 13:14 [PATCH 0/6] i40e VMDQ support Chen Jing D(Mark)
[not found] ` <1411478047-1251-1-git-send-email-jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-23 13:14 ` [PATCH 1/6] ether: enhancement for " Chen Jing D(Mark)
[not found] ` <1411478047-1251-2-git-send-email-jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-14 14:09 ` Thomas Monjalon
2014-10-15 6:59 ` Chen, Jing D
[not found] ` <4341B239C0EFF9468EE453F9E9F4604D015F35FE-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-15 8:10 ` Thomas Monjalon
2014-10-15 9:47 ` Chen, Jing D
[not found] ` <4341B239C0EFF9468EE453F9E9F4604D015F36E1-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-15 9:59 ` Thomas Monjalon
2014-10-16 10:07 ` [PATCH v2 0/6] i40e " Chen Jing D(Mark)
[not found] ` <1413454046-13407-1-git-send-email-jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-16 10:07 ` [PATCH v2 1/6] ether: enhancement for " Chen Jing D(Mark)
[not found] ` <1413454046-13407-2-git-send-email-jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-03 22:17 ` Thomas Monjalon
2014-11-04 5:50 ` Chen, Jing D
[not found] ` <4341B239C0EFF9468EE453F9E9F4604D016061A7-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-04 8:53 ` Thomas Monjalon [this message]
2014-11-04 8:59 ` Chen, Jing D
2014-10-16 10:07 ` [PATCH v2 2/6] igb: change for VMDQ arguments expansion Chen Jing D(Mark)
[not found] ` <1413454046-13407-3-git-send-email-jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-03 18:37 ` Thomas Monjalon
2014-11-04 5:26 ` Chen, Jing D
2014-10-16 10:07 ` [PATCH v2 3/6] ixgbe: " Chen Jing D(Mark)
2014-10-16 10:07 ` [PATCH v2 4/6] i40e: add VMDQ support Chen Jing D(Mark)
[not found] ` <1413454046-13407-5-git-send-email-jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-03 18:33 ` Thomas Monjalon
2014-11-04 5:22 ` Chen, Jing D
2014-10-16 10:07 ` [PATCH v2 5/6] i40e: macaddr add/del enhancement Chen Jing D(Mark)
2014-10-16 10:07 ` [PATCH v2 6/6] i40e: Add full VMDQ pools support Chen Jing D(Mark)
2014-10-21 3:30 ` [PATCH v2 0/6] i40e VMDQ support Cao, Min
2014-11-03 7:54 ` Chen, Jing D
2014-11-04 10:01 ` [PATCH v3 " Chen Jing D(Mark)
[not found] ` <1415095289-28961-1-git-send-email-jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-04 10:01 ` [PATCH v3 1/6] ether: enhancement for " Chen Jing D(Mark)
2014-11-04 10:01 ` [PATCH v3 2/6] igb: change for VMDQ arguments expansion Chen Jing D(Mark)
2014-11-04 10:01 ` [PATCH v3 3/6] ixgbe: " Chen Jing D(Mark)
2014-11-04 10:01 ` [PATCH v3 4/6] i40e: add VMDQ support Chen Jing D(Mark)
2014-11-04 10:01 ` [PATCH v3 5/6] i40e: macaddr add/del enhancement Chen Jing D(Mark)
2014-11-04 10:01 ` [PATCH v3 6/6] i40e: Add full VMDQ pools support Chen Jing D(Mark)
2014-11-04 11:19 ` [PATCH v3 0/6] i40e VMDQ support Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB977258213A249C-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-04 23:17 ` Thomas Monjalon
2014-12-11 6:09 ` Cao, Min
2014-09-23 13:14 ` [PATCH 2/6] igb: change for VMDQ arguments expansion Chen Jing D(Mark)
2014-09-23 13:14 ` [PATCH 3/6] ixgbe: " Chen Jing D(Mark)
2014-09-23 13:14 ` [PATCH 4/6] i40e: add VMDQ support Chen Jing D(Mark)
[not found] ` <1411478047-1251-5-git-send-email-jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-13 16:14 ` De Lara Guarch, Pablo
2014-09-23 13:14 ` [PATCH 5/6] i40e: macaddr add/del enhancement Chen Jing D(Mark)
[not found] ` <1411478047-1251-6-git-send-email-jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-14 14:25 ` Thomas Monjalon
2014-10-15 7:01 ` Chen, Jing D
2014-09-23 13:14 ` [PATCH 6/6] i40e: Add full VMDQ pools support Chen Jing D(Mark)
2014-10-10 10:45 ` [PATCH 0/6] i40e VMDQ support Ananyev, Konstantin
2014-10-14 8:27 ` Chen, Jing D
2014-10-21 3:30 ` Cao, Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3494957.2Q8m5MX3oE@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).