From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/6] ether: enhancement for VMDQ support Date: Tue, 04 Nov 2014 09:53:43 +0100 Message-ID: <3494957.2Q8m5MX3oE@xps13> References: <1411478047-1251-2-git-send-email-jing.d.chen@intel.com> <48821528.yaSnYYWibr@xps13> <4341B239C0EFF9468EE453F9E9F4604D016061A7@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Chen, Jing D" Return-path: In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D016061A7-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-11-04 05:50, Chen, Jing D: > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > > 2014-10-16 18:07, Chen Jing D: > > > + /** Specify the queue range belongs to VMDQ pools if VMDQ > > applicable. */ > > > + uint16_t vmdq_queue_base; > > > + uint16_t vmdq_queue_num; > > > > Please explain what mean the values in vmdq_queue_base and > > vmdq_queue_num. > > I thinks the name is self- explanatory, I also add some comments for them. > As previous max_rx/tx_queues indicates how many queues available, these > 2 variables defines the queue ranges for VM usage. I understand clearly now. > What kind of explanations you needs me to add? You cannot put a doxygen comment which apply to 2 fields. Try do describe precisely the meaning of each field. Example: /**< first queue ID in the range for VMDQ pool */ and /**< size of the queue range for VMDQ pool */ -- Thomas