From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH v3] build: use generic march on arm64 when
 using 'default' machine
Date: Wed, 27 Feb 2019 12:15:50 +0000
Message-ID: <34a4bbb558f997f406f342edb2e6a4134f75b403.camel@debian.org>
References: <20181224125627.25690-1-bluca@debian.org>
 <20190107141130.24360-1-bluca@debian.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com
 [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 1B5295699
 for <dev@dpdk.org>; Wed, 27 Feb 2019 13:15:53 +0100 (CET)
Received: by mail-wm1-f65.google.com with SMTP id e74so5562304wmg.3
 for <dev@dpdk.org>; Wed, 27 Feb 2019 04:15:53 -0800 (PST)
Received: from localhost ([2a01:4b00:f419:6f00:b00c:66c8:99df:336])
 by smtp.gmail.com with ESMTPSA id p16sm33763564wro.25.2019.02.27.04.15.50
 for <dev@dpdk.org>
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 27 Feb 2019 04:15:50 -0800 (PST)
In-Reply-To: <20190107141130.24360-1-bluca@debian.org>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 2019-01-07 at 14:11 +0000, Luca Boccassi wrote:
> When building for generic distribution we need a stable baseline
> architecture, or depending on the build worker the result will vary.
>=20
> Force the default flags if the user explicitly sets machine=3Ddefault
> at configuration time.
>=20
> Fixes: b1d48c41189a ("build: support ARM with meson")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> v2: fix typo in commit message, remove variable used only once
> v3: put back temporary variable, as "machine" gets overwritten
>     by the function and loses the original value before we need
>     it.
>=20
>  config/arm/meson.build | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>=20
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index dae55d6b2..614139534 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -6,6 +6,7 @@
>  march_opt =3D '-march=3D@0@'.format(machine)
> =20
>  arm_force_native_march =3D false
> +arm_force_default_march =3D (machine =3D=3D 'default')
> =20
>  machine_args_generic =3D [
>  	['default', ['-march=3Darmv8-a+crc+crypto']],
> @@ -105,7 +106,11 @@ else
>  	cmd_generic =3D ['generic', '', '', 'default', '']
>  	cmd_output =3D cmd_generic # Set generic by default
>  	machine_args =3D [] # Clear previous machine args
> -	if not meson.is_cross_build()
> +	if arm_force_default_march and not meson.is_cross_build()
> +		machine =3D impl_generic
> +		cmd_output =3D cmd_generic
> +		impl_pn =3D 'default'
> +	elif not meson.is_cross_build()
>  		# The script returns ['Implementer', 'Variant',
> 'Architecture',
>  		# 'Primary Part number', 'Revision']
>  		detect_vendor =3D find_program(join_paths(

Ping - anything else I can do for this patch? It's necessary for distro
native builds, at least in Debian/Ubuntu. Thanks!

--=20
Kind regards,
Luca Boccassi