From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2 1/2] net: remove dead driver names Date: Thu, 24 Nov 2016 11:42:49 +0000 Message-ID: <34e127bd-1f8c-46ea-f602-1f39cb08b698@intel.com> References: <1478785884-29273-1-git-send-email-david.marchand@6wind.com> <1479751574-5704-1-git-send-email-david.marchand@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, jblunck@infradead.org, linville@tuxdriver.com, declan.doherty@intel.com, zlu@ezchip.com, lsun@ezchip.com, alejandro.lucero@netronome.com, mtetsuyah@gmail.com, nicolas.pernas.maradei@emutex.com, harish.patil@qlogic.com, rasesh.mody@qlogic.com, sony.chacko@qlogic.com, bruce.richardson@intel.com, huawei.xie@intel.com, yuanhan.liu@linux.intel.com, jianfeng.tan@intel.com To: David Marchand , thomas.monjalon@6wind.com Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8AFF25585 for ; Thu, 24 Nov 2016 12:42:55 +0100 (CET) In-Reply-To: <1479751574-5704-1-git-send-email-david.marchand@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/21/2016 6:06 PM, David Marchand wrote: > Since commit b1fb53a39d88 ("ethdev: remove some PCI specific handling"), > rte_eth_dev_info_get() relies on dev->data->drv_name to report the driver > name to caller. > > Having the pmds set driver_info->driver_name in the pmds is useless, > since ethdev overwrites it right after. > The only thing the pmd must do is: > - for pci drivers, call rte_eth_copy_pci_info() which then sets > data->drv_name > - for vdev drivers, manually set data->drv_name > > At this stage, virtio-user does not properly report a driver name (fixed in > next commit). > > Signed-off-by: David Marchand > Reviewed-by: Ferruh Yigit > Reviewed-by: Jan Blunck Series applied to dpdk-next-net/master, thanks.