From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL Date: Fri, 07 Oct 2016 15:45:04 +0200 Message-ID: <3500403.rczxDexAsB@xps13> References: <1475847187-28967-1-git-send-email-shreyansh.jain@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: david.marchand@6wind.com, dev@dpdk.org To: Shreyansh Jain Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 29BCD5683 for ; Fri, 7 Oct 2016 15:45:06 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id f193so33744749wmg.0 for ; Fri, 07 Oct 2016 06:45:06 -0700 (PDT) In-Reply-To: <1475847187-28967-1-git-send-email-shreyansh.jain@nxp.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-10-07 19:03, Shreyansh Jain: > DRIVER_REGISTER_PCI -> EAL_REGISTER_PCI > DRIVER_REGISTER_PCI_TABLE -> EAL_REGISTER_PCI_TABLE Why not RTE_ prefix instead of EAL_? Why 3 patches? As there is no specific comment in each, I think you can squash.