From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 01/18] net/axgbe: add minimal dev init and
 uninit support
Date: Fri, 16 Mar 2018 17:42:18 +0000
Message-ID: <350657d3-8d92-0545-5e05-39ab1b4cadfc@intel.com>
References: <1515145938-97474-1-git-send-email-Ravi1.kumar@amd.com>
 <1520584954-130575-1-git-send-email-Ravi1.kumar@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
To: Ravi Kumar <Ravi1.kumar@amd.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 294AB5F5D
 for <dev@dpdk.org>; Fri, 16 Mar 2018 18:42:21 +0100 (CET)
In-Reply-To: <1520584954-130575-1-git-send-email-Ravi1.kumar@amd.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/9/2018 8:42 AM, Ravi Kumar wrote:
> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>

<...>

> @@ -412,6 +412,12 @@ CONFIG_RTE_PMD_RING_MAX_TX_RINGS=16
>  CONFIG_RTE_LIBRTE_PMD_SOFTNIC=y
>  
>  #
> +# Compile AMD PMD
> +#
> +CONFIG_RTE_LIBRTE_AXGBE_PMD=y
> +CONFIG_RTE_LIBRTE_AXGBE_DEBUG_INIT=n

Config file recently updated to have PMD options sorted alphabetically, can you
please move config option according.

<...>

> +/* The set of PCI devices this driver supports */
> +#define AMD_PCI_VENDOR_ID       0x1022
> +#define AMD_PCI_AXGBE_DEVICE_ID1 0x1458
> +#define AMD_PCI_AXGBE_DEVICE_ID2 0x1459

More descriptive name can help others to find which devices are supported,
instead of id1 and id2.

<...>

> +static int
> +eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)
> +{
> +	PMD_INIT_FUNC_TRACE();
> +	struct axgbe_port *pdata;
> +	struct rte_pci_device *pci_dev;
> +
> +	pdata = (struct axgbe_port *)eth_dev->data->dev_private;
> +	pdata->eth_dev = eth_dev;

Since there is already a RTE_PROC_PRIMARY check below, these should be below
that check because secondary doesn't need to update pdata->eth_dev

<...>

> +RTE_PMD_REGISTER_PCI(net_axgbe, rte_axgbe_pmd);
> +RTE_PMD_REGISTER_PCI_TABLE(net_axgbe, pci_id_axgbe_map);
> +RTE_PMD_REGISTER_KMOD_DEP(net_axgbe, "* igb_uio | uio_pci_generic");

Is vfio-pci intentionally not included as dependency?

> +
> +RTE_INIT(axgbe_init_log);
> +static void
> +axgbe_init_log(void)
> +{
> +	axgbe_logtype_init = rte_log_register("pmd.axgbe.init");

The log string syntax updated, now it should be "pmd.net.axgbe.*"

<...>

> +#ifdef RTE_LIBRTE_AXGBE_DEBUG_INIT
> +#define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, " >>")
> +#else
> +#define PMD_INIT_FUNC_TRACE() do { } while (0)
> +#endif

Do we need this config option? The idea of dynamic logging is get rid of them.
If you want to control trace logs seperately, you can create a new logtype for
it can control dynamically. As long as it is not in datapath we can remove log
config options.

> +extern int axgbe_logtype_driver;
> +#define PMD_DRV_LOG_RAW(level, fmt, args...) \
> +	rte_log(RTE_LOG_ ## level, axgbe_logtype_driver, "%s(): " fmt, \
> +		__func__, ## args)
> +
> +#define PMD_DRV_LOG(level, fmt, args...) \
> +	PMD_DRV_LOG_RAW(level, fmt "\n", ## args)

Do you need interim PMD_DRV_LOG_RAW? Why not directly define PMD_DRV_LOG?

<...>