From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH dpdk v2] vfio/ppc64/spapr: Warn if DMA window
	was created at unexpected offset
Date: Wed, 18 Oct 2017 08:24:34 +0200
Message-ID: <3509725.R4iCQoWzDS@xps>
References: <20170426080908.24026-1-aik@ozlabs.ru> <1734105.V98Xar4r66@xps>
 <65996a36-e64e-248c-d22b-cd9db1ba5e3f@ozlabs.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "Burakov, Anatoly" <anatoly.burakov@intel.com>, dev@dpdk.org
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 55E561B5EB
 for <dev@dpdk.org>; Wed, 18 Oct 2017 08:24:36 +0200 (CEST)
In-Reply-To: <65996a36-e64e-248c-d22b-cd9db1ba5e3f@ozlabs.ru>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

18/10/2017 07:11, Alexey Kardashevskiy:
> On 18/10/17 03:13, Thomas Monjalon wrote:
> > 28/04/2017 13:19, Burakov, Anatoly:
> >> From: Alexey Kardashevskiy
> >>> VFIO_IOMMU_SPAPR_TCE_CREATE ioctl() returns the actual bus address for
> >>> just created DMA window. It happens to start from zero because the default
> >>> window is removed (leaving no windows) and new window starts from zero.
> >>> However this is not guaranteed and a new window may start from another
> >>> address, this adds a check and an error message.
> >>>
> >>>
> >>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> >>> ---
> >>> Changes:
> >>> v2:
> >>> * this just prints warning and fails instead of incorrectly changing IOVA
> >>> addresses
> >>> ---
> >>
> >> Hi Alexey,
> >>
> >> There are some compile failures with this patch. You'll probably want to replace %lx with PRIx64 or similar :)
> >>
> >> I would argue that just saying "DMA offsets other than zero are not supported" will be sufficient and will make error message less confusing. Up to you though.
> > 
> > Please, can we progress on this patch?
> > Is it still a relevant patch?
> 
> Nope, http://dpdk.org/browse/dpdk/commit/?id=ed1e7e576be219e1e has the
> warning, this is enough really.

OK, I've marked it as superseded in patchwork.
Thanks