From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2] app/testpmd: unify help strings
Date: Tue, 06 Dec 2016 14:32:36 +0100
Message-ID: <3514749.EJIcXcugSX@xps13>
References: <20161202013727.2117-1-ferruh.yigit@intel.com>
 <20161202015845.7121-1-ferruh.yigit@intel.com>
 <B27915DBBA3421428155699D51E4CFE20266D23D@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>, "De Lara Guarch,
 Pablo" <pablo.de.lara.guarch@intel.com>, "Wu,
 Jingjing" <jingjing.wu@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wj0-f180.google.com (mail-wj0-f180.google.com
 [209.85.210.180]) by dpdk.org (Postfix) with ESMTP id E53342BB3
 for <dev@dpdk.org>; Tue,  6 Dec 2016 14:32:38 +0100 (CET)
Received: by mail-wj0-f180.google.com with SMTP id xy5so321090598wjc.0
 for <dev@dpdk.org>; Tue, 06 Dec 2016 05:32:38 -0800 (PST)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE20266D23D@IRSMSX103.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> > Formatted as:
> > cmd fixed_string fixed|string|options <variable>: Description
> > 
> > If there is no description, final colon emitted.
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> 
> Good refactoring work to give consistency. It might be worth having a look at the testpmd docs to see if some of the same improvements can be made there as well. That could be a separate patch.
> 
> >  	.f = cmd_config_rss_hash_key_parsed,
> >  	.data = NULL,
> > -	.help_str =
> > -		"port config X rss-hash-key ipv4|ipv4-frag|ipv4-tcp|ipv4-udp|"
> > -		"ipv4-sctp|ipv4-other|ipv6|ipv6-frag|ipv6-tcp|ipv6-udp|"
> > -		"ipv6-sctp|ipv6-other|l2-payload|"
> > -		"ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex "
> > -		"<string of hexa digits (variable length, NIC dependent)>\n",
> > +	.help_str = "port config <port_id> rss-hash-key "
> > +		"ipv4|ipv4-frag|ipv4-tcp|ipv4-udp|ipv4-sctp|ipv4-other|"
> > +		"ipv6|ipv6-frag|ipv6-tcp|ipv6-udp|ipv6-sctp|ipv6-other|"
> > +		"l2-payload|ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex "
> > +		"<string of hexa digits (variable length, NIC dependent)>",
> 
> /hex/hexa/

fixed

> Apart from that:
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks