From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v7 11/11] devtools: prevent new instances of rte_panic and rte_exit Date: Wed, 25 Apr 2018 01:03:20 +0200 Message-ID: <3515084.lgnKaFBshB@xps> References: <1524608213-2080-1-git-send-email-arnon@qwilt.com> <1524608213-2080-12-git-send-email-arnon@qwilt.com> <20180424155253.7a11479f@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Arnon Warshavsky , anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, dev@dpdk.org To: Stephen Hemminger Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 971414C99 for ; Wed, 25 Apr 2018 01:03:24 +0200 (CEST) In-Reply-To: <20180424155253.7a11479f@xeon-e3> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/04/2018 00:52, Stephen Hemminger: > On Wed, 25 Apr 2018 01:16:53 +0300 > Arnon Warshavsky wrote: > > > This patch adds a new function that is called > > per every checked patch, > > and alerts for new instances of rte_panic/rte_exit. > > The check excludes comments, and alerts in the case > > of a positive balance between additions and removals. > > > > Signed-off-by: Arnon Warshavsky > > Why not just mark the functions as deprecated with compiler attribute. No, the applications can use these functions.