From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 4/4] app/testpmd: add isolated mode
	parameter
Date: Tue, 27 Jun 2017 10:28:51 +0200
Message-ID: <3515786.3Gc2XbLCYg@xps>
References: <0dca86aa1372d6ff09d0aff01d522c580e0e24ab.1495717153.git.vasilyf@mellanox.com>
 <AM4PR0501MB26896736C1579D254960D25FDBDA0@AM4PR0501MB2689.eurprd05.prod.outlook.com>
 <9BB6961774997848B5B42BEC655768F810DAC7A8@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Vasily Philipov <vasilyf@mellanox.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 =?ISO-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 9342B374
 for <dev@dpdk.org>; Tue, 27 Jun 2017 10:28:53 +0200 (CEST)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810DAC7A8@SHSMSX103.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

22/06/2017 03:13, Wu, Jingjing:
> From: Vasily Philipov [mailto:vasilyf@mellanox.com]
> > From: Wu, Jingjing [mailto:jingjing.wu@intel.com]
> > >
> > > > +/*
> > > >   * Avoids to check link status when starting/stopping a port.
> > > >   */
> > > >  uint8_t no_link_check = 0; /* check by default */ @@ -1422,6
> > > > +1427,15 @@ static void eth_event_callback(uint8_t port_id,
> > > >  		if (port->need_reconfig > 0) {
> > > >  			port->need_reconfig = 0;
> > > >
> > > > +			if (isolated_mode) {
> > > > +				int ret = port_flow_isolate(pi, 1);
> > > > +				if (ret) {
> > > > +					printf("Failed to apply isolated"
> > > > +					       " mode on port %d\n", pi);
> > > > +					return -1;
> > > > +				}
> > > > +			}
> > > > +
> > > Should it block the app startup if isolated-mode setting fails?
> > 
> > if isolated mode cannot be enabled on any port, that port cannot be initialized
> > and that causes testpmd to quit, at least it won't go against the user's wishes
> 
> If so, I prefer the isolated_mode to be port's argument but not global one.
> How about to add a command to configure the isolate mode?

There is already a command to configure isolate mode per-port:
	http://dpdk.org/patch/25320
	http://dpdk.org/doc/guides/testpmd_app_ug/testpmd_funcs.html#flow-syntax

I think it does not make sense to replicate this per-port command in
command line parameters.
All the other parameters are global:
	http://dpdk.org/doc/guides/testpmd_app_ug/run_app.html#testpmd-command-line-options
The idea here is to have a global isolate mode with a general option.