From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH] devtools: don't use bash extension in checkpatches Date: Sat, 15 Sep 2018 23:07:00 +0200 Message-ID: <3518082.x84fBL49uy@xps> References: <6831653.AvvoQPlBBt@xps> <20180914150818eucas1p299538375ea77dfc477516918818c3ab8~UTLGIgMNr0598905989eucas1p2k@eucas1p2.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Arnon Warshavsky , dev@dpdk.org, Stephen Hemminger , Andrzej Ostruszka To: Ilya Maximets Return-path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 34C0434F3 for ; Sat, 15 Sep 2018 23:07:05 +0200 (CEST) In-Reply-To: <20180914150818eucas1p299538375ea77dfc477516918818c3ab8~UTLGIgMNr0598905989eucas1p2k@eucas1p2.samsung.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/09/2018 17:10, Ilya Maximets: > Hi Thomas. > > Beside your questions, > There is another patch that targeted to fix this issue: > http://patches.dpdk.org/patch/44020/ > And one similar to mine that I missed while sending: > http://patches.dpdk.org/patch/43692/ > > So, I'm not sure which one should be accepted and if I need to > update my version. What do you think? Stephen? Andrzej? Generally speaking, I think it's better to avoid bash extensions and comply with POSIX. That's why I support the proposal of moving the awk script in its own file, removing the need for "read -d".