From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kevin Traynor <ktraynor@redhat.com>
Subject: Re: [RFC 2/2] net/i40e: update requested queue pair num
 check for rounding
Date: Mon, 11 Mar 2019 18:38:28 +0000
Message-ID: <3536cc53-0a13-f5db-1238-a84c9b70f413@redhat.com>
References: <20190305163039.16790-1-ktraynor@redhat.com>
 <20190305163039.16790-2-ktraynor@redhat.com>
 <039ED4275CED7440929022BC67E706115334A38D@SHSMSX103.ccr.corp.intel.com>
 <b68bf6f0-d73f-a644-3408-6f466805170a@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Yan, Zhirun" <zhirun.yan@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 0FD74378B
 for <dev@dpdk.org>; Mon, 11 Mar 2019 19:38:36 +0100 (CET)
In-Reply-To: <b68bf6f0-d73f-a644-3408-6f466805170a@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/03/2019 12:35, Ferruh Yigit wrote:
> On 3/11/2019 2:18 AM, Zhang, Qi Z wrote:
>>
>>
>>> -----Original Message-----
>>> From: Kevin Traynor [mailto:ktraynor@redhat.com]
>>> Sent: Wednesday, March 6, 2019 12:31 AM
>>> To: Zhang, Qi Z <qi.z.zhang@intel.com>
>>> Cc: dev@dpdk.org; Kevin Traynor <ktraynor@redhat.com>; Yan, Zhirun
>>> <zhirun.yan@intel.com>
>>> Subject: [RFC 2/2] net/i40e: update requested queue pair num check for
>>> rounding
>>>
>>> Since rounding up the requested queue pairs to allow the vf to request a
>>> non-aligned number was added, it may happen that the requested number is
>>> less than the available num of queues but the rounded up number is greater. In
>>> this case, it is not caught with the usual checks but later when there is a reset and
>>> failed setup.
>>>
>>> By rounding earlier the checks can be done before a failed reset occurs, and a
>>> rounded max amount of available queues can be returned to the vf.
>>>
>>> Cc: zhirun.yan@intel.com
>>> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
>>
>> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>>
>> Applied to dpdk-next-net-intel.
>>
> 
> These were checkpatch warnings because of whitespace (spaces before tabs), fixed
> while merging to next-net.
> 

Thanks Ferruh. Not spaces before tabs, but using spaces for alignment
where there was room for an additional tab. I misinterpreted "spaces for
alignment" in the CS note. Maybe it's clear for others, but I'll send a
small clarification so I'll remember next time :-)