From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3] ethdev: return diagnostic when setting
	MAC address
Date: Tue, 10 Apr 2018 15:19:45 +0200
Message-ID: <35427873.7xcNz5HcYd@xps>
References: <20180403124103.13124-1-olivier.matz@6wind.com>
 <20180406153444.23988-1-olivier.matz@6wind.com>
 <43422766-0111-4b93-1eb2-39cd6f48a4a1@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
 Tomasz Duszynski <tdu@semihalf.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>, Ivan Malov <ivan.malov@oktetlabs.ru>
To: Olivier Matz <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 99AA81B7C7
 for <dev@dpdk.org>; Tue, 10 Apr 2018 15:19:48 +0200 (CEST)
In-Reply-To: <43422766-0111-4b93-1eb2-39cd6f48a4a1@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

06/04/2018 18:03, Ferruh Yigit:
> On 4/6/2018 4:34 PM, Olivier Matz wrote:
> > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a
> > return code is added to notify the caller (librte_ether) if an error
> > occurred in the PMD.
> > 
> > The new default MAC address is now copied in dev->data->mac_addrs[0]
> > only if the operation is successful.
> > 
> > The patch also updates all the PMDs accordingly.
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> > Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>