From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] test/metrics: Fixed a negative case to
	pass
Date: Sun, 20 Jan 2019 22:31:52 +0100
Message-ID: <3592747.moUssd9yEs@xps>
References: <20181206150106.154090-1-hkalra@marvell.com>
 <20181210083857.3158-1-hkalra@marvell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "remy.horton@intel.com" <remy.horton@intel.com>,
 "jerin.jacobkollanukkaran@cavium.com" <jerin.jacobkollanukkaran@cavium.com>
To: Harman Kalra <hkalra@marvell.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 9F39232A5
 for <dev@dpdk.org>; Sun, 20 Jan 2019 22:31:55 +0100 (CET)
In-Reply-To: <20181210083857.3158-1-hkalra@marvell.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

10/12/2018 09:39, Harman Kalra:
> Negative test case for passing invalid count size to
> rte_metrics_update_values() will pass if count value
> is any value greater than 1 because set size wrt to
> key id 1 is 1 and passing 0 as no of values to be
> updated will not hit the ERANGE check.
> 
> Signed-off-by: Harman Kalra <hkalra@marvell.com>

Adding comment from Remy:
Fixes: cd3804242901 ("test/metrics: add unit tests for metrics library")
Acked-by: Remy Horton <remy.horton@intel.com>

Applied, thanks