From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] telemetry: fix error when using ports of
	different types
Date: Fri, 21 Dec 2018 00:51:26 +0100
Message-ID: <35952782.MrcKBpYm8b@xps>
References: <20181219115950.46386-1-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 stable@dpdk.org
To: Kevin Laatz <kevin.laatz@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20181219115950.46386-1-bruce.richardson@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

19/12/2018 12:59, Bruce Richardson:
> Different NIC ports can have different numbers of xstats on them, which
> means that we can't just use the xstats list from the first port registered
> in the telemetry library. Instead, we need to check the type of each port -
> by checking its ops structure pointer - and register each port type once
> with the metrics lib.
> 
> CC: stable@dpdk.org
> Fixes: fdbdb3f9ce46 ("telemetry: add initial connection socket")
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Kevin, any comment please?