Re: [REVIEW] doc/nfb: cleanup and update guide

Stephen Hemminger
2026-02-02T17:51:06Z

On Mon, 2 Feb 2026 09:42:35 -0800
Stephen Hemminger <stephen@networkplumber.org> wrote:

> ## Patch 2/8: net/nfb: create one ethdev per ethernet port
>
> ### Errors
>
> 1. **`__rte_internal` functions in header file without the tag appearing alone on its own line** (nfb.h:89-92)
> ```c
> __rte_internal
> int nfb_eth_common_probe(struct nfb_probe_params *params);
> __rte_internal
> int nfb_eth_common_remove(struct rte_device *dev);
> ```
> The `__rte_internal` tag should be alone on its line, but the function signature should have the return type on a separate line per DPDK style:
> ```c
> __rte_internal
> int
> nfb_eth_common_probe(struct nfb_probe_params *params);
> ```

Definately a false positive, ignore this.