Re: [PATCH v7 0/8] net/nfb: rework to real multiport

Martin Špinler
2026-02-13T18:54:39Z

> Patch 1/8 (Queue Mapping):
>     Missing NULL checks before accessing queue_map_rx/tx arrays
> (could crash in secondary process)

Fixed with the new "ready" bit in device private struct.
However, I'm not sure, if/how the secondary process can pass init
before the primary.

> Patch 2/8 (Core Refactoring):
>     Resource leak: nfb_dev not closed on error path

Nonsense, the nfb_close is already exactly there.

>     Partial device cleanup missing on errors

The title and partially the description doesn't make sense.
The cleanup in nfb_eth_common_remove() for failed
nfb_eth_dev_create_for_ifc() is clear in my opinion.

All other problems fixed in v8 and mentioned in cover letter, thanks.