Re: [PATCH v2 0/8] net/nfb: rework to real multiport

Martin Spinler
2026-01-20T15:16:36Z

On Mon, 2026-01-19 at 18:25 -0800, Stephen Hemminger wrote:
>
> You still are using int for queue_max_rx and tx which seems wrong.

The queue_maP_rx problem I'm describing in another email.

> In general, this driver code seems to use int like old C code from K&R era.
> Avoid using strtol() if you only want unsigned values.
>
> Don't use RTE_ASSERT() for error checking, it gets compiled out usually.
> Instead check for snprintf overflows and return EINVAL or ENAMETOOLONG error.
>
>
> Some comments from AI reviewers.
> ....

Ack. Thanks, I will incorporate all your and AI comments, except for
DYNANIC (correct) and __rte_internal (other drivers use the same
layout).