From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [dpdk-stable] [PATCH v2] net/vmxnet3: fix dereference before null check Date: Mon, 2 Oct 2017 22:45:55 +0100 Message-ID: <35c2fd54-ffcf-597e-c9d0-a8ca4f7ba8f1@intel.com> References: <20170922123906.13308-1-michalx.k.jastrzebski@intel.com> <20170929130402.32196-1-michalx.k.jastrzebski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, deepak.k.jain@intel.com, yongwang@vmware.com, stable@dpdk.org, Tomasz Kulasek To: Michal Jastrzebski , skhare@vmware.com Return-path: In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/2/2017 10:39 PM, Ferruh Yigit wrote: > On 9/29/2017 2:04 PM, Michal Jastrzebski wrote: >> Coverity reports check_after_deref: >> Null-checking rq suggests that it may be null, but it >> has already been dereferenced on all paths leading to >> the check. >> This patch removes NULL checking of "rq" from function >> vmxnet3_dev_rx_queue_reset as it is already checked against NULL >> one level up the callstack (function vmxnet3_dev_clear_queues). >> >> Coverity issue: 143468 >> Fixes: 5aecdc17a97d ("vmxnet3: fix stop/restart") >> Cc: yongwang@vmware.com >> Cc: stable@dpdk.org >> >> Signed-off-by: Tomasz Kulasek >> Signed-off-by: Michal Jastrzebski > > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.