From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Hunt, David" <david.hunt@intel.com>
Subject: Re: [PATCH v2 2/4] power: clean up of acpi files
Date: Mon, 11 Dec 2017 10:44:53 +0000
Message-ID: <35d56aa1-3dc6-f6ee-0ab8-5ac02fb6c778@intel.com>
References: <20171128132203.43181-1-marko.kovacevic@intel.com>
 <20171128132203.43181-2-marko.kovacevic@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Marko Kovacevic <marko.kovacevic@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 353362BAE
 for <dev@dpdk.org>; Mon, 11 Dec 2017 11:44:55 +0100 (CET)
In-Reply-To: <20171128132203.43181-2-marko.kovacevic@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Marko,


On 28/11/2017 1:22 PM, Marko Kovacevic wrote:
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
> ---
>   lib/librte_power/Makefile                          |  2 +-
>   ...e_power_acpi_cpufreq.c => power_acpi_cpufreq.c} | 32 +++++++++++-----------
>   ...e_power_acpi_cpufreq.h => power_acpi_cpufreq.h} | 28 +++++++++----------
>   lib/librte_power/rte_power.c                       | 28 +++++++++----------
>   4 files changed, 45 insertions(+), 45 deletions(-)
>   rename lib/librte_power/{rte_power_acpi_cpufreq.c => power_acpi_cpufreq.c} (94%)
>   rename lib/librte_power/{rte_power_acpi_cpufreq.h => power_acpi_cpufreq.h} (88%)
>
> diff --git a/lib/librte_power/Makefile b/lib/librte_power/Makefile
> index 1b1491d..bf5a55e 100644
> --- a/lib/librte_power/Makefile
> +++ b/lib/librte_power/Makefile
> @@ -42,7 +42,7 @@ EXPORT_MAP := rte_power_version.map
>   LIBABIVER := 1
>   
>   # all source are stored in SRCS-y
> -SRCS-$(CONFIG_RTE_LIBRTE_POWER) := rte_power.c rte_power_acpi_cpufreq.c
> +SRCS-$(CONFIG_RTE_LIBRTE_POWER) := rte_power.c power_acpi_cpufreq.c
>   SRCS-$(CONFIG_RTE_LIBRTE_POWER) += rte_power_kvm_vm.c guest_channel.c
>   
>   # install this header file
> diff --git a/lib/librte_power/rte_power_acpi_cpufreq.c b/lib/librte_power/power_acpi_cpufreq.c
> similarity index 94%
> rename from lib/librte_power/rte_power_acpi_cpufreq.c
> rename to lib/librte_power/power_acpi_cpufreq.c

--snip--

Could I suggest adding the following to the commit message?

"Rename private header file rte_power_acpi_cpufreq.c to 
power_acpi_cpufreq.c. This prevents the private functions from leaking 
into the documentation.
Change any private functions from rte_<function_name> to just 
<function_name>. Reserve the rte_ for public functions. "

Regards,
Dave.