From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 2/2] vhost: realloc virtio_net and virtqueue
	to the same node of vring desc table
Date: Wed, 17 Jun 2015 19:02:22 +0200
Message-ID: <3608606.ARMOZ1d8vj@xps13>
References: <1432778661-25428-1-git-send-email-huawei.xie@intel.com>
 <1433474005-597-3-git-send-email-huawei.xie@intel.com>
 <4795082.KHkHrmv5EW@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Huawei Xie <huawei.xie@intel.com>, Tommy Long <thomas.long@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com
 [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 6B01DC4C2
 for <dev@dpdk.org>; Wed, 17 Jun 2015 19:03:23 +0200 (CEST)
Received: by wiwd19 with SMTP id d19so139991807wiw.0
 for <dev@dpdk.org>; Wed, 17 Jun 2015 10:03:23 -0700 (PDT)
In-Reply-To: <4795082.KHkHrmv5EW@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-06-17 18:47, Thomas Monjalon:
> 2015-06-05 11:13, Huawei Xie:
> > --- a/mk/rte.app.mk
> > +++ b/mk/rte.app.mk
> > @@ -92,6 +92,9 @@ endif # ! CONFIG_RTE_BUILD_COMBINE_LIBS
> > =20
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_PCAP)       +=3D -lpcap
> > =20
> > +ifeq ($(CONFIG_RTE_LIBRTE_VHOST_NUMA),y)
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST)          +=3D -lnuma
> > +
> >  ifeq ($(CONFIG_RTE_LIBRTE_VHOST_USER),n)
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST)          +=3D -lfuse
> >  endif
>=20
> An endif is missing.

After adding the endif and enabling the NUMA option, these errors appea=
r:

lib/librte_vhost/virtio-net.c:535:21: error: =E2=80=98new_vq=E2=80=99 m=
ay be used uninitialized in this function
lib/librte_vhost/virtio-net.c:547:63: error: =E2=80=98new_ll_dev=E2=80=99=
 may be used uninitialized in this function

Tommy,
I won't review the code, but given it doesn't build, I can guess how it=
 has
been reviewed.
Acked-by line is valuable only if the review is carefully done.

This patch series go back to lowest merge priority.