From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [RFC 00/14] link status API improvement and bugfixes Date: Fri, 05 Jan 2018 15:29:09 +0100 Message-ID: <3614502.L0iXJskvX9@xps> References: <20170714183027.16021-1-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, arybchenko@solarflare.com To: Stephen Hemminger Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E462F1B024 for ; Fri, 5 Jan 2018 15:29:30 +0100 (CET) In-Reply-To: <20170714183027.16021-1-stephen@networkplumber.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/07/2017 20:30, Stephen Hemminger: > While writing new driver, I noticed a lot of unnecessary duplication of > code in drivers for handling the eth_dev link status information. While > consolidating this, it also became obvious that several drivers have > bugs in this are because they don't return the correct value. > Also, some drivers were not fully initializing all the space (including > padding). Good initiative. Please, could you spin a new version not RFC? > This is compile test only at this point, I don't have any of the hardware > available (except virtio) to test. I think we should integrate it in 18.02-rc1 so everybody will be forced to test it.