From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] ip_pipeline: add flow actions pipeline Date: Fri, 13 Nov 2015 17:32:25 +0100 Message-ID: <3632155.sWGWsa4oGk@xps13> References: <1447432188-5033-1-git-send-email-roy.fan.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Maciej Gajdzica To: dev@dpdk.org, Fan Zhang Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 219C095A3 for ; Fri, 13 Nov 2015 17:33:41 +0100 (CET) Received: by wmdw130 with SMTP id w130so36118034wmd.0 for ; Fri, 13 Nov 2015 08:33:41 -0800 (PST) In-Reply-To: <1447432188-5033-1-git-send-email-roy.fan.zhang@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-11-13 16:29, Fan Zhang: > examples/ip_pipeline/Makefile | 2 + > examples/ip_pipeline/app.h | 1 + > examples/ip_pipeline/init.c | 4 + > .../ip_pipeline/pipeline/pipeline_actions_common.h | 83 + > examples/ip_pipeline/pipeline/pipeline_common_fe.h | 5 +- > examples/ip_pipeline/pipeline/pipeline_firewall.c | 10 +- > .../ip_pipeline/pipeline/pipeline_flow_actions.c | 1814 ++++++++++++++++++++ > .../ip_pipeline/pipeline/pipeline_flow_actions.h | 78 + > .../pipeline/pipeline_flow_actions_be.c | 973 +++++++++++ > .../pipeline/pipeline_flow_actions_be.h | 168 ++ > .../pipeline/pipeline_flow_classification.c | 18 +- > examples/ip_pipeline/pipeline/pipeline_routing.c | 22 +- > 12 files changed, 3155 insertions(+), 23 deletions(-) It is a huge patch, especially for an example. It may cause some code update more difficult to maintain. I wonder wether we should have some line number limits for the examples?