From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 1/1] net/mlx5: add hardware TSO support
Date: Mon, 6 Mar 2017 09:31:14 +0000
Message-ID: <36403dfc-932b-65a4-a527-c33de20074d2@intel.com>
References: <1488366702-51373-1-git-send-email-shahafs@mellanox.com>
 <1488445291-24637-1-git-send-email-shahafs@mellanox.com>
 <8379d78f-4448-f6b3-0f24-5ab23561a3af@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Shahaf Shuler <shahafs@mellanox.com>, nelio.laranjeiro@6wind.com,
 adrien.mazarguil@6wind.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 01492952
 for <dev@dpdk.org>; Mon,  6 Mar 2017 10:31:17 +0100 (CET)
In-Reply-To: <8379d78f-4448-f6b3-0f24-5ab23561a3af@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/6/2017 8:50 AM, Ferruh Yigit wrote:
> On 3/2/2017 9:01 AM, Shahaf Shuler wrote:
>> Implement support for hardware TSO.
>>
>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
>> ---
>> on v3:
>>  * fix alignment issues
>>  * for warn log
>> on v2:
>>  * Instead of exposing capability, TSO checks on data path.
>>  * PMD specific parameter to enable TSO.
>>  * different implementaion for the data path.
>>    Performance impact ~0.1-0.2Mpps
> 
> Hi Shahaf,
> 
> I think it is good idea to update release notes to announce mlx5 TSO
> support, what do you think?

Since [1] depends on this patch, I will get both, but can you please
send a separate patch for release notes?

[1]
http://dpdk.org/dev/patchwork/patch/21065/

> 
> And if you will send a new version of the patch, can you please put
> "TSO" flag in the same order with default.ini

I will update this.

> 
> Thanks,
> ferruh
>