From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] eal:Change log output to DEBUG instead of
	INFO
Date: Thu, 18 Feb 2016 15:08:49 +0100
Message-ID: <3641912.UTtuKLG1Jr@xps13>
References: <1441914050-43168-1-git-send-email-keith.wiles@intel.com>
 <1928276.P2Lqin6BEp@xps13>
 <C6ECDF3AB251BE4894318F4E45123697820C85AF@IRSMSX109.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id D9B82C37E
 for <dev@dpdk.org>; Thu, 18 Feb 2016 15:10:22 +0100 (CET)
Received: by mail-wm0-f51.google.com with SMTP id g62so29544488wme.1
 for <dev@dpdk.org>; Thu, 18 Feb 2016 06:10:22 -0800 (PST)
In-Reply-To: <C6ECDF3AB251BE4894318F4E45123697820C85AF@IRSMSX109.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-02-18 10:18, Burakov, Anatoly:
> > > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > > @@ -904,7 +904,7 @@ pci_vfio_enable(void)
> > >
> > >  	/* return 0 if VFIO modules not loaded */
> > >  	if (module_vfio_type1 == 0) {
> > > -		RTE_LOG(INFO, EAL, "VFIO modules not all loaded, "
> > > +		RTE_LOG(DEBUG, EAL, "VFIO modules not all loaded, "
> > >  			"skip VFIO support...\n");
> > >  		return 0;
> > >  	}
> 
> Should people be forced to recompile DPDK with debug logs (and get all this
> additional debug output) just to see why VFIO doesn't get initialized?

No, there is a run-time option --log-level.
The compiled max level must be set to DEBUG to be able to see this message
with debug --log-level.

> I would
> argue this message is not as serious an annoyance to warrant this change, but
> maybe Keith has a different opinion.
> 
> Either way, I don't feel strongly for or against the change.

Thanks