From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] check-symbol-change: fix regex to match on end of map file Date: Thu, 01 Nov 2018 23:53:00 +0100 Message-ID: <3649242.bmXl2ZTEod@xps> References: <20181101135410.15945-1-nhorman@tuxdriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, doucette@bu.edu To: Neil Horman Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 4FC1D1B274 for ; Thu, 1 Nov 2018 23:53:04 +0100 (CET) In-Reply-To: <20181101135410.15945-1-nhorman@tuxdriver.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/11/2018 14:54, Neil Horman: > the regex to determine the end of the map file chunk in a patch seems to > be wrong, It was using perl regex syntax, which awk doesn't appear to > support (I'm still not sure how it was working previously). Regardless, > it wasn't triggering and as a result symbols were getting added to the > mapdb that shouldn't be there. > > Fix it by converting the regex to use traditional posix syntax, matching > only on the negation of the character class [^map] > > Tested and shown to be working on the ip_frag patch set provided by > doucette@bu.edu > > Signed-off-by: Neil Horman > CC: thomas@monjalon.net > CC: doucette@bu.edu > Reported-by: doucette@bu.edu You could use these lines: Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") Reported-by: Cody Doucette > --- a/devtools/check-symbol-change.sh > +++ b/devtools/check-symbol-change.sh > - /[-+] a\/.*\.^(map)/ {in_map=0} > + /[-+] a\/.*\.[^map]/ {in_map=0} Not sure this is what you intend: [^map] means any character except "m", "a" and "p". I don't know whether awk supports this syntax: (?!foo)