From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCHv5 11/33] bus/fslmc: add vfio support
Date: Fri, 20 Jan 2017 10:28:44 +0530
Message-ID: <36524717-481d-0fb1-5909-36f42fde7164@nxp.com>
References: <1484679174-4174-1-git-send-email-hemant.agrawal@nxp.com>
 <1484832240-2048-1-git-send-email-hemant.agrawal@nxp.com>
 <1484832240-2048-14-git-send-email-hemant.agrawal@nxp.com>
 <2924620.aWMzQZgCCD@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <bruce.richardson@intel.com>, <shreyansh.jain@nxp.com>,
 <john.mcnamara@intel.com>, <ferruh.yigit@intel.com>,
 <jerin.jacob@caviumnetworks.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam02on0043.outbound.protection.outlook.com [104.47.36.43])
 by dpdk.org (Postfix) with ESMTP id 6C3142B9B
 for <dev@dpdk.org>; Fri, 20 Jan 2017 05:58:55 +0100 (CET)
In-Reply-To: <2924620.aWMzQZgCCD@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/19/2017 10:53 PM, Thomas Monjalon wrote:
> 2017-01-19 18:53, Hemant Agrawal:
>> @@ -45,8 +45,10 @@ DPDK_17.02 {
>>          dpseci_open;
>>          dpseci_reset;
>>          dpseci_set_rx_queue;
>> +        mcp_ptr_list;
>>          rte_fslmc_driver_register;
>>          rte_fslmc_driver_unregister;
>> +        vfio_dmamap_mem_region;
>
> These symbols do not comply with the DPDK namespace (rte_*).
>

We can add the rte_* for the bus exported functions.

do you have a concerns w.r.t dpseci_open type symbols also?

How do we do it?

They are only required to be added in map to resolve the dependency of 
PMD on BUS.
These are low level functions provided by the mc bus and referenced by 
the different NXP PMDs e.g. NET or CRYPTO, they are not suppose to be 
externally exposed functions.