From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v4 06/21] testpmd: add test commands to
	add/delete flow director filter
Date: Tue, 28 Oct 2014 14:23:41 +0100
Message-ID: <3655691.pDuQDRK5Z6@xps13>
References: <1411711418-12881-1-git-send-email-jingjing.wu@intel.com>
 <1413939687-11177-1-git-send-email-jingjing.wu@intel.com>
 <1413939687-11177-7-git-send-email-jingjing.wu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Jingjing Wu <jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1413939687-11177-7-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-10-22 09:01, Jingjing Wu:
> --- a/app/test-pmd/testpmd.h
> +++ b/app/test-pmd/testpmd.h
> @@ -73,6 +73,9 @@ int main(int argc, char **argv);
>  #define NUMA_NO_CONFIG 0xFF
>  #define UMA_NO_CONFIG  0xFF
>  
> +#define BYTES_PER_WORD  2

This is an example of a constant which have a meaning.
But it should be in lib/librte_eal/common/include/rte_common.h

> +#define IPV6_ADDR_LEN 16

This one should be in lib/librte_net/rte_ip.h and should be used in ipv6_hdr.

Thanks
-- 
Thomas