From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal: fix strdup usages in internal config Date: Mon, 14 Jan 2019 15:18:29 +0100 Message-ID: <3667118.sJRdelqhzi@xps> References: <4e041e83fb00d8d818682997f795928c36b3283a.1547127516.git.anatoly.burakov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Bruce Richardson , ferruh.yigit@intel.com, andy01011501@163.com To: Anatoly Burakov Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id A00614C91 for ; Mon, 14 Jan 2019 15:18:32 +0100 (CET) In-Reply-To: <4e041e83fb00d8d818682997f795928c36b3283a.1547127516.git.anatoly.burakov@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/01/2019 14:38, Anatoly Burakov: > Currently, we use strdup in a few places to store command-line > parameter values for certain internal config values. There are > several issues with that. > > First of all, they're never freed, so memory ends up leaking > either after EAL exit, or when these command-line options are > supplied multiple times. > > Second of all, they're defined as `const char *`, so they > *cannot* be freed even if we wanted to. > > Finally, strdup may return NULL, which will be stored in the > config. For most fields, NULL is a valid value, but for the > default prefix, the value is always expected to be valid. > > To fix all of this, three things are done. First, we change > the definitions of these values to `char *` as opposed to > `const char *`. This does not break the ABI, and previous > code assumes constness (which is more restrictive), so it's > safe to do so. > > Then, fix all usages of strdup to check return value, and add > a cleanup function that will free the memory occupied by > these strings, as well as freeing them before assigning a new > value to prevent leaks when parameter is specified multiple > times. > > And finally, add an internal API to query hugefile prefix, so > that, absent of a valid value, a default value will be > returned, and also fix up all usages of hugefile prefix to > use this API instead of accessing hugefile prefix directly. > > Bugzilla ID: 108 > > Signed-off-by: Anatoly Burakov Applied, thanks