From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2 1/2] service: add mechanism for quiescing
	a service
Date: Tue, 19 Jun 2018 00:13:56 +0200
Message-ID: <3685961.S7279KZuIK@xps>
References: <20180531135557.7544-1-gage.eads@intel.com>
 <20180614135130.30849-1-gage.eads@intel.com>
 <20180614135130.30849-2-gage.eads@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com,
 bruce.richardson@intel.com, nikhil.rao@intel.com, erik.g.carrillo@intel.com,
 abhinandan.gujjar@intel.com
To: Gage Eads <gage.eads@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 485EF2C16
 for <dev@dpdk.org>; Tue, 19 Jun 2018 00:13:59 +0200 (CEST)
In-Reply-To: <20180614135130.30849-2-gage.eads@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

14/06/2018 15:51, Gage Eads:
> --- a/lib/librte_eal/common/include/rte_service.h
> +++ b/lib/librte_eal/common/include/rte_service.h
> @@ -162,6 +162,22 @@ int32_t rte_service_runstate_set(uint32_t id, uint32_t runstate);
>  int32_t rte_service_runstate_get(uint32_t id);
>  
>  /**
> + * This function returns whether the service may be currently executing on
> + * at least one lcore, or definitely is not. This function can be used to
> + * determine if, after setting the service runstate to stopped, the service
> + * is still executing an a service lcore.

Typo: "an a"

> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> +DPDK_18.08 {
> +	global:
> +
> +	rte_service_may_be_active;
> +
> +} DPDK_18.05;

Why it is not experimental?