From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2 2/2] Fix variable assignment.
Date: Thu, 28 Feb 2019 12:14:23 +0100
Message-ID: <3696913.gDqFAc8s5c@xps>
References: <20190213190813.12702-1-msantana@redhat.com>
 <20190214193547.30783-1-msantana@redhat.com>
 <20190214193547.30783-3-msantana@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Van Haaren Harry <harry.van.haaren@intel.com>,
 ramirose@gmail.com, Bruce Richardson <bruce.richardson@intel.com>
To: Michael Santana <msantana@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id BFE5A2C38
 for <dev@dpdk.org>; Thu, 28 Feb 2019 12:14:34 +0100 (CET)
In-Reply-To: <20190214193547.30783-3-msantana@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

Few minor comments,

The title should start with "devtools:" and not end with dot.
One suggestion:
	devtools: fix result of svg include check

14/02/2019 20:35, Michael Santana:
> Fix trivial bug. In sh shell, 'foo = 1' is not the same as
> 'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo
> as a command, rather than a simple variable assignment.

Yes, good catch, thanks.

> Signed-off-by: Michael Santana <msantana@redhat.com>
> Fixes: dafc04c15174 ("hash: fix out-of-bound write while freeing key slot")

The reference should be:
Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
and it should be followed by:
Cc: stable@dpdk.org
in order to be backported.