From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v5 12/19] devargs: generic device
	representation
Date: Wed, 28 Jun 2017 09:44:18 +0200
Message-ID: <3705717.5YLzOZFs93@xps>
References: <cover.1496876859.git.gaetan.rivet@6wind.com>
 <cover.1498001626.git.gaetan.rivet@6wind.com>
 <c8ae6dd379be3c94f895fc8d59585e74d1461ec8.1498001626.git.gaetan.rivet@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id E64DF2BE1
 for <dev@dpdk.org>; Wed, 28 Jun 2017 09:44:20 +0200 (CEST)
In-Reply-To: <c8ae6dd379be3c94f895fc8d59585e74d1461ec8.1498001626.git.gaetan.rivet@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

21/06/2017 01:35, Gaetan Rivet:
> Remove the dependency of this subsystem upon bus specific device
> representation.
> 
> Devargs only validates that a device declaration is correct and handled
> by a bus. The device interpretation is done afterward within the bus.
> 
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
>  app/test-pmd/testpmd.c                      |  9 ++----
>  lib/librte_eal/common/eal_common_devargs.c  | 48 +++++------------------------
>  lib/librte_eal/common/eal_common_pci.c      |  9 ++++--
>  lib/librte_eal/common/eal_common_vdev.c     | 17 +++++-----
>  lib/librte_eal/common/include/rte_devargs.h | 16 ++--------
>  lib/librte_eal/common/include/rte_vdev.h    |  2 +-
>  test/test/test_devargs.c                    |  9 ++----
>  7 files changed, 30 insertions(+), 80 deletions(-)

Is it correct to add this change when rebasing?

--- a/lib/librte_eal/common/eal_common_pci.c
+++ b/lib/librte_eal/common/eal_common_pci.c
@@ -533,7 +533,7 @@ pci_plug(struct rte_devargs *da)
        struct rte_pci_device *pdev;
        struct rte_pci_addr *addr;
 
-       addr = &da->pci.addr;
+       da->bus->parse(da->name, &addr);
        /*
         * Update eventual pci device in global list.
         * Insert it if none was found.