From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] compat: fix symbol version support with meson Date: Mon, 17 Sep 2018 10:42:24 +0200 Message-ID: <3722786.uIPfu17pdJ@xps> References: <20180830170701.21443-1-bruce.richardson@intel.com> <20180917081800.8912-1-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, bluca@debian.org, stable@dpdk.org To: Bruce Richardson Return-path: In-Reply-To: <20180917081800.8912-1-bruce.richardson@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/09/2018 10:18, Bruce Richardson: > For meson builds, the define to enable the symbol version > macros in rte_compat.h was missing. This led to symbols being > omitted from shared objects. For example, checking rte_distributor.so > with objdump and comparing make and meson built versions: > > $ objdump -T make-build/lib/librte_distributor.so | grep _flush > 0000000000001b60 g DF .text 00000000000000a7 (DPDK_2.0) rte_distributor_flush > 0000000000003f10 g DF .text 0000000000000434 DPDK_17.05 rte_distributor_flush > $ objdump -T meson-build/lib/librte_distributor.so | grep _flush > 0000000000001d50 g DF .text 00000000000000fb DPDK_2.0 rte_distributor_flush > > Adding in the missing define fixes this. > > Fixes: 5b9656b157d3 ("lib: build with meson") > > CC: stable@dpdk.org > Reported-by: Luca Boccassi > Signed-off-by: Bruce Richardson > Tested-by: Luca Boccassi Applied, thanks